Hey Yu, in general, it's very useful for a reviewer to have responses to comments, even if they are just "Done". The typical workflow is to prepare a new patch, respond to comments, and then push your new patch to gerrit. No need to abandon in between.
Thanks for your continued effort :). Will review your new patch. Alex On Tue, May 30, 2017 at 8:33 AM, yu feng (Code Review) <[email protected]> wrote: > yu feng has abandoned this change. > > Change subject: IMPALA-5016: Simplify coalesce() in > SimplifyConditionalsRule and do static partition pruning with coalesce() > function. > ...................................................................... > > > Abandoned > > Simplify the implement and add some tests. > > -- > To view, visit http://gerrit.cloudera.org:8080/6990 > To unsubscribe, visit http://gerrit.cloudera.org:8080/settings > > Gerrit-MessageType: abandon > Gerrit-Change-Id: I0b57267ce68ef882d73120b5054603b72867c7f5 > Gerrit-PatchSet: 1 > Gerrit-Project: Impala-ASF > Gerrit-Branch: master > Gerrit-Owner: yu feng <[email protected]> > Gerrit-Reviewer: Alex Behm <[email protected]> > Gerrit-Reviewer: Jim Apple <[email protected]> >
