Tim Armstrong has posted comments on this change. Change subject: IMPALA-5400: Execute tests in subplans.test ......................................................................
Patch Set 1: Code-Review+1 (1 comment) Change looks good, my only question is whether we need the test coverage. It looks like the tests are not redundant with other tests. http://gerrit.cloudera.org:8080/#/c/7038/1/testdata/workloads/functional-query/queries/QueryTest/subplans.test File testdata/workloads/functional-query/queries/QueryTest/subplans.test: Line 229: 16 > These tests have not been running for a while. It looks like the things you fixed were invalid beforehand (unquoted strings, wrong # of types). It looks like Alex added the tests so he may know whether this is missing coverage or whether the nested types tests cover this. -- To view, visit http://gerrit.cloudera.org:8080/7038 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I02b4f47553fb8f5fe3425cde2e0bcb3245c39b91 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: anujphadke <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: anujphadke <[email protected]> Gerrit-HasComments: Yes
