Michael Ho has posted comments on this change. Change subject: IMPALA-5419: Check for cancellation when building hash tables ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7047/1/be/src/exec/partitioned-hash-join-builder.cc File be/src/exec/partitioned-hash-join-builder.cc: PS1, Line 690: RETURN_IF_ERROR(state->GetQueryStatus()); > Ah, that doesn't match with this then: RETURN_IF_CANCELLED(state) will return Status::CANCELLED. -- To view, visit http://gerrit.cloudera.org:8080/7047 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8047f532f55dc0118f7a843c91275f752c8a190d Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Michael Ho <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-HasComments: Yes
