Marcel Kornacker has posted comments on this change. Change subject: IMPALA-5381: Adds DEFAULT_JOIN_STRATEGY query option. ......................................................................
Patch Set 1: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/7059/1/common/thrift/ImpalaInternalService.thrift File common/thrift/ImpalaInternalService.thrift: Line 60: enum TJoinStrategy { call this join distribution or distribution mode to differentiate this (more clearly) from the join algorithm (in preparation for a time where we have more than one join algorithm)? strategy seems ambiguous. -- To view, visit http://gerrit.cloudera.org:8080/7059 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibd34442f422129d53bef5493fc9cbe7375a0765c Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Marcel Kornacker <mar...@cloudera.com> Gerrit-HasComments: Yes
