John Sherman has posted comments on this change. Change subject: IMPALA-5394: Set socket timeouts while opening TSaslTransport ......................................................................
Patch Set 1: > Thanks for submitting this John. Was there any testing you did to > validate this patch? Also, how did you decide on the 5 second > value? I did manual testing on my dev machine. I'm in the process of getting my specific build on a cluster with kerberos enabled to be able to test the specific timeout case. The patch was originally verified against an older version of the code base in a kerberized environment. I'm also attempting to get the impala regression testdata loaded onto my test machine and having very little luck, so I can run the full impala regression suite. Is there a way for me to remotely run this against the impala test suite? As for the value of 5, I honestly just picked a number that seemed safe. I think perhaps it is a bit high. I think the timeout for internal connections is 3 seconds. -- To view, visit http://gerrit.cloudera.org:8080/7061 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I56a5f3d9cf931cff14eae7f236fea018236a6255 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: John Sherman <[email protected]> Gerrit-Reviewer: John Sherman <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-HasComments: No
