John Russell has posted comments on this change. Change subject: IMPALA-5348: [DOCS] Add CAST to string literal + INTERVAL example ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7067/1/docs/topics/impala_literals.xml File docs/topics/impala_literals.xml: Line 302: such as <codeph>CAST('1966-07-30' AS TIMESTAMP) + INTERVAL 5 YEARS + INTERVAL 3 DAYS</codeph>. See > Cool, thanks for doing this. Does it make sense to mention explicitly that I would say no because the example is correct regardless of the status of IMPALA-1503, while if I added more detail that would mean more changes to unwind after IMPALA-1503 was closed - I'd say that's an unnecessary maintenance burden. -- To view, visit http://gerrit.cloudera.org:8080/7067 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3e2af386176e7c310ced221fa77d73c97a9f8590 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: John Russell <[email protected]> Gerrit-Reviewer: John Russell <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-HasComments: Yes
