Tim Armstrong has posted comments on this change. Change subject: IMPALA-4192: Disentangle Expr and ExprContext ......................................................................
Patch Set 17: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/5483/17/be/src/exec/aggregation-node.cc File be/src/exec/aggregation-node.cc: Line 92: new SlotRef(desc) : new SlotRef(desc, TYPE_BOOLEAN)); Tab? http://gerrit.cloudera.org:8080/#/c/5483/17/be/src/exprs/scalar-expr.cc File be/src/exprs/scalar-expr.cc: Line 96: for (const TExpr& texpr: texprs) { I was even thinking it might be less error-prone if, on failure, this closed all of the exprs it created and cleared the vector. Removes an edge case from the caller. Ok to ignore. -- To view, visit http://gerrit.cloudera.org:8080/5483 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iefdc9aeeba033355cb9497e3a5d2363627dcf2f3 Gerrit-PatchSet: 17 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Michael Ho <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
