Tim Armstrong has posted comments on this change. Change subject: IMPALA-5432: Remove invalid DCHECK from SetMemLimitExceeded ......................................................................
Patch Set 1: Code-Review+2 (1 comment) Thanks for fixing this. I agree with your analysis - the DCHECK is bogus. http://gerrit.cloudera.org:8080/#/c/7075/1/be/src/runtime/runtime-state.cc File be/src/runtime/runtime-state.cc: Line 240 > I can move this check up to where we set query_status_ or set a variable to Removing it seems fine to me. If I was leaving it I'd probably leave it here and make it DCHECK(!status.ok()) so it's checking the method postcondition. -- To view, visit http://gerrit.cloudera.org:8080/7075 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1c03048ad15739baf7e68ca8d50930f3c45e71c5 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: John Sherman <[email protected]> Gerrit-Reviewer: John Sherman <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
