Marcel Kornacker has posted comments on this change. Change subject: IMPALA-5347: reduce codegen overhead of timestamp trunc() ......................................................................
Patch Set 2: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/7081/2/be/src/exprs/udf-builtins.cc File be/src/exprs/udf-builtins.cc: Line 16: // under the License. mention somewhere that these functions should specifically not get cross-compiled (otherwise the next person might decide there's something to be gained from ...). -- To view, visit http://gerrit.cloudera.org:8080/7081 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I222258f51b2093a38929df847fdb5d25bb9aafc3 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Marcel Kornacker <mar...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-HasComments: Yes
