Alex Behm has posted comments on this change. Change subject: IMPALA-4850 [DOCS] Create table "comment comes after "partioned by" ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7080/1/docs/topics/impala_create_table.xml File docs/topics/impala_create_table.xml: Line 172: <ph rev="2.9.0 IMPALA-4850">[COMMENT '<varname>table_comment</varname>']</ph> There seem to be a few things amiss. The correct order can be seen from our code in sql-parser.cup: tbl_options ::= opt_sort_cols:sort_cols opt_comment_val:comment row_format_val:row_format serde_properties:serde_props file_format_create_table_val:file_format location_val:location cache_op_val:cache_op tbl_properties:tbl_props {: CreateTableStmt.unescapeProperties(serde_props); CreateTableStmt.unescapeProperties(tbl_props); RESULT = new TableDef.Options(sort_cols, comment, row_format, serde_props, file_format, location, cache_op, tbl_props); :} ; 1. Table comment comes immediately after PARTITIONED BY. 2. ROW FORMAT comes before WITH SERDEPROPERTIES Might be good to play around with CREATE TABLE to confirm what exactly the syntax is. -- To view, visit http://gerrit.cloudera.org:8080/7080 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I543ff1dbfe1ab8a7e0a0a668130ab060e3af0a5f Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Laurel Hale <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: John Russell <[email protected]> Gerrit-HasComments: Yes
