Alex Behm has posted comments on this change. Change subject: IMPALA-5438: Always eval union const exprs in subplan. ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7091/1/testdata/workloads/functional-query/queries/QueryTest/nested-types-subplan.test File testdata/workloads/functional-query/queries/QueryTest/nested-types-subplan.test: Line 592: ---- QUERY > I think we should validate the results of this query. Maybe check the num This test is crafted such that we expect an empty result set. In the old buggy code, this query returned a non-empty result set. I verified that this test fails without the fix. I expanded the comment to explain what result we expect. -- To view, visit http://gerrit.cloudera.org:8080/7091 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icd2f21f0213188e2304f8e9536019c7940c07768 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Alex Behm <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: anujphadke <[email protected]> Gerrit-HasComments: Yes
