Lars Volker has posted comments on this change. Change subject: IMPALA-5315 Cast to timestamp fails for YYYY-M-D format ......................................................................
Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/7009/2/be/src/exprs/expr-test.cc File be/src/exprs/expr-test.cc: Line 2210: // Test casting of lazy date and/or month format string to timestamp nit: this should probably now read day, not date. http://gerrit.cloudera.org:8080/#/c/7009/2/be/src/runtime/timestamp-parse-util.cc File be/src/runtime/timestamp-parse-util.cc: PS2, Line 260: DEFAULT_LAZY_DATE_FMT_LEN Maybe it would be clearer to replace these with DEFAULT_DATE_FMT_LEN-1 and DEFAULT_DATE_FMT_LEN-2. That way it's more obvious what the difference is, i.e. they're shorter by one character. What do you think? -- To view, visit http://gerrit.cloudera.org:8080/7009 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib9a184a09d7e7783f04d47588537612c2ecec28f Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Vincent Tran <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Vincent Tran <[email protected]> Gerrit-HasComments: Yes
