John Sherman has posted comments on this change. Change subject: IMPALA-5394: Set socket timeouts while opening TSaslTransport ......................................................................
Patch Set 2: > Thanks for the write-up, very helpful! I'll give that a try. I think the hard part would be in selecting the thread pool size in TAcceptQueue::serve. Because lets say I set it to 5 and the flaky client tries to connect 5 times within the tcp keep alive period, then impalad is back in the situation of not being able to accept connections until the sockets start timing out. I'm tempted to keep the timeouts combined with switching to the TAcceptQueue implementation. I'll read the code a bit more to get a better understanding. -- To view, visit http://gerrit.cloudera.org:8080/7061 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I56a5f3d9cf931cff14eae7f236fea018236a6255 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: John Sherman <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: John Sherman <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-HasComments: No
