Dan Hecht has posted comments on this change. Change subject: IMPALA-4164: Avoid overly aggressive inlining in LLVM IR ......................................................................
Patch Set 9: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/6941/8/be/src/codegen/llvm-codegen.cc File be/src/codegen/llvm-codegen.cc: PS8, Line 706: target_features_attr_ > I guess it's a tad faster by not reassembling the same string over and over I doubt the overhead matters but I'm fine with leaving it. -- To view, visit http://gerrit.cloudera.org:8080/6941 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2d87ae8d222b415587e7320cb9072e4a8d6615ce Gerrit-PatchSet: 9 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Michael Ho <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
