Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4965: Authorize access to runtime profile and exec summary ......................................................................
Patch Set 7: (6 comments) http://gerrit.cloudera.org:8080/#/c/7064/7/be/src/service/client-request-state.h File be/src/service/client-request-state.h: Line 218: const ClientRequestState& request_state); > Agree. Your solution is simpler, let's do that. Done Line 327: bool user_has_profile_access_; > comment what exactly this means (like you have in QueryStateRecord) Done http://gerrit.cloudera.org:8080/#/c/7064/7/be/src/service/impala-beeswax-server.cc File be/src/service/impala-beeswax-server.cc: PS7, Line 355: GetSessionState(session_id, &session) > you should just pass '&session' as the second param to WithSession to get t Done PS7, Line 375: GetSessionState(session_id, &session) > you should just pass '&session' as the second param to WithSession to get t Done http://gerrit.cloudera.org:8080/#/c/7064/7/be/src/service/impala-server.h File be/src/service/impala-server.h: Line 638: const QueryStateRecord& query_record); > Same comment as above. Removed http://gerrit.cloudera.org:8080/#/c/7064/7/be/src/util/auth-util.h File be/src/util/auth-util.h: Line 45: Status CheckProfileAccess(const std::string& user, const std::string& effective_user, > this needs documentation, including what the parameters mean. i.e. not obvi Done -- To view, visit http://gerrit.cloudera.org:8080/7064 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2255d587367c2d328590ae8534a5406c4b0c9b15 Gerrit-PatchSet: 7 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-HasComments: Yes
