Michael Ho has posted comments on this change. Change subject: IMPALA-4192: Disentangle Expr and ExprContext ......................................................................
Patch Set 19: (8 comments) http://gerrit.cloudera.org:8080/#/c/5483/19/be/src/exec/analytic-eval-node.h File be/src/exec/analytic-eval-node.h: Line 304: /// analytic_eval_fns_. When enough input rows have been consumed to produce the analytic > long lines Done http://gerrit.cloudera.org:8080/#/c/5483/19/be/src/exec/exec-node.cc File be/src/exec/exec-node.cc: Line 498: // %eval_ptr = getelementptr inbounds %"class.impala::ScalarExprEvaluator"*, > trailing Done http://gerrit.cloudera.org:8080/#/c/5483/19/be/src/exec/hbase-scan-node.cc File be/src/exec/hbase-scan-node.cc: Line 250: if (EvalConjuncts(&conjunct_evals_[0], conjuncts_.size(), row)) { > .data() Done http://gerrit.cloudera.org:8080/#/c/5483/19/be/src/exec/hdfs-parquet-scanner.cc File be/src/exec/hdfs-parquet-scanner.cc: Line 1238: if (ExecNode::EvalConjuncts(&evals[0], evals.size(), row)) { > .data() Done http://gerrit.cloudera.org:8080/#/c/5483/19/be/src/exec/partitioned-aggregation-node.cc File be/src/exec/partitioned-aggregation-node.cc: Line 1410: // %input0 = call { i8, double } @GetSlotRef(%"class.impala::ScalarExprEvaluator"* > trailing Done http://gerrit.cloudera.org:8080/#/c/5483/19/be/src/exprs/scalar-expr-evaluator.cc File be/src/exprs/scalar-expr-evaluator.cc: Line 218: for (int i = 0; i < evals.size(); ++i) { > single line Done http://gerrit.cloudera.org:8080/#/c/5483/19/be/src/runtime/data-stream-test.cc File be/src/runtime/data-stream-test.cc: Line 307: is_asc_, nulls_first_)); > tab TupleRowComparator will keep a reference to is_asc_ so it needs to exist after calling the constructor. http://gerrit.cloudera.org:8080/#/c/5483/19/be/src/util/tuple-row-compare.h File be/src/util/tuple-row-compare.h: Line 141: std::vector<int8_t> nulls_first_; > const& here as well? Not feasible given the way it's set up in the constructor. -- To view, visit http://gerrit.cloudera.org:8080/5483 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iefdc9aeeba033355cb9497e3a5d2363627dcf2f3 Gerrit-PatchSet: 19 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Michael Ho <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
