Sailesh Mukil has posted comments on this change. Change subject: IMPALA-5221: Avoid re-use of stale SASL contexts. ......................................................................
Patch Set 4: Code-Review+2 (3 comments) Thanks for the review! Carry +2. I'll run it through one last round of testing and merge it after that. http://gerrit.cloudera.org:8080/#/c/7116/3/be/src/transport/TSasl.cpp File be/src/transport/TSasl.cpp: Line 115: mechList(mechanisms) { > Is it right to initialise chosenMech to a list of mechanisms? Should it sta Good point. It shouldn't make a difference, but I've removed it anyway. I'll just run it though one last round of testing to make sure that this doesn't cause a regression. http://gerrit.cloudera.org:8080/#/c/7116/3/be/src/transport/TSasl.h File be/src/transport/TSasl.h: PS3, Line 125: * > nit: line break Done http://gerrit.cloudera.org:8080/#/c/7116/3/be/src/transport/TSaslTransport.h File be/src/transport/TSaslTransport.h: PS3, Line 177: /** > nit: three / (or better to conform to other function comment style in this Done -- To view, visit http://gerrit.cloudera.org:8080/7116 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7d509e14dfe46fa28d0626cf84daf6de82955d80 Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-HasComments: Yes
