Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5031: Don't dereference uninitialized memory as a bool. ......................................................................
IMPALA-5031: Don't dereference uninitialized memory as a bool. Every bool takes up a byte of memory, but not every byte of memory is a valid bool. Dereferencing that memory, even if only to write to, it is undefined behavior. I tested exhaustive UBSAN and DEBUG. In UBSAN, the error is no longer present; in both UBSAN and DEBUG, all tests pass Change-Id: Ibc03401a9aeb966f33298268e53ab1040d007224 Reviewed-on: http://gerrit.cloudera.org:8080/7148 Reviewed-by: Jim Apple <jbapple-imp...@apache.org> Tested-by: Impala Public Jenkins --- M be/src/runtime/raw-value.cc 1 file changed, 5 insertions(+), 1 deletion(-) Approvals: Impala Public Jenkins: Verified Jim Apple: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/7148 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibc03401a9aeb966f33298268e53ab1040d007224 Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Jim Apple <jbapple-imp...@apache.org> Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple <jbapple-imp...@apache.org> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com>
