Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-5492:There is an error in impala-shell introduction when using LDAP ......................................................................
Patch Set 2: (3 comments) Thanks for submitting the patch. Mind fix a couple of nits? http://gerrit.cloudera.org:8080/#/c/7166/2//COMMIT_MSG Commit Message: Line 7: IMPALA-5492:There is an error in impala-shell introduction when using LDAP nit: Space after the jira key, something like "IMPALA-5492: <subject>". (This helps gerrit interpret the jira as an URL) PS2, Line 7: There is an error in impala-shell introduction when using LDAP May be edit this to convey what the commit is actually fixing, something like, "Fix incorrect newline character in the LDAP message" PS2, Line 9: The introduction has redundant '\n' in impala-shell when using LDAP. : : I fix this issue by deleting the redundant '\n' in introduction when : impala-shell using LDAP. May be reword to "Remove extraneous '\' .."? Looks like you are not removing the the \n, just the extra '\' in the beginning. -- To view, visit http://gerrit.cloudera.org:8080/7166 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I30c601ab255a4882260f7be23b5763ef8ec76d28 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Donghui Xu <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-HasComments: Yes
