Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5446: dropped Sorter::Reset() status ......................................................................
IMPALA-5446: dropped Sorter::Reset() status This patch aligns the sorter's methods closer with the ExecNode methods and moves the possibly-failing parts of Reset() into Open(). Testing: Added WARN_UNUSED_RESULT to all the sorter methods that return Status to prevent similar issues in future. Add a test that sometimes goes down this code path. It was able to cause a crash at least once every 5 executions. Ran an exhaustive build to make sure there were no other regressions. Change-Id: I7d4f9e93a44531901e663b3f1e18edc514363f74 Reviewed-on: http://gerrit.cloudera.org:8080/7134 Reviewed-by: Tim Armstrong <[email protected]> Tested-by: Impala Public Jenkins --- M be/src/exec/sort-node.cc M be/src/runtime/sorter.cc M be/src/runtime/sorter.h M testdata/workloads/functional-query/queries/QueryTest/nested-types-tpch.test 4 files changed, 43 insertions(+), 21 deletions(-) Approvals: Impala Public Jenkins: Verified Tim Armstrong: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/7134 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7d4f9e93a44531901e663b3f1e18edc514363f74 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: anujphadke <[email protected]>
