Henry Robinson has posted comments on this change.

Change subject: IMPALA-5506: Add stdin description to help information of 
query_file option
......................................................................


Patch Set 1:

(1 comment)

Thanks for doing this!

http://gerrit.cloudera.org:8080/#/c/7178/1/shell/option_parser.py
File shell/option_parser.py:

Line 87:                     help="Execute the queries in the query file or 
from STDIN indicated by - and end input with ctrl+d, delimited by ;")
Please wrap to 90 chars.

The message is good - but may I suggest a minor reword? How about:

"Execute the queries in the query file, delimited by ;. Queries
  may be read from stdin if the argument to -f is -."


-- 
To view, visit http://gerrit.cloudera.org:8080/7178
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0264174fd062497c72891b31cf9ac1ba6c00f716
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Donghui Xu <[email protected]>
Gerrit-Reviewer: Henry Robinson <[email protected]>
Gerrit-HasComments: Yes

Reply via email to