Tim Armstrong has posted comments on this change. Change subject: IMPALA-5488: Fix handling of exclusive HDFS file handles ......................................................................
Patch Set 1: Code-Review+1 (2 comments) The changes make sense to me. It's subtle so would be good to get another pair of eyes on it. http://gerrit.cloudera.org:8080/#/c/7181/1/be/src/runtime/disk-io-mgr-scan-range.cc File be/src/runtime/disk-io-mgr-scan-range.cc: Line 304: // Destroy the file handle and remove it from the cache Nit: period at end for consistency? Line 351: // Destroy the file handle and remove it from the cache Nit: period at end for consistency? -- To view, visit http://gerrit.cloudera.org:8080/7181 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4c03696984285cc9ce463edd969c5149cd83a861 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
