Lars Volker has posted comments on this change. Change subject: IMPALA-5499: avoid ephemeral port conflicts ......................................................................
Patch Set 2: Code-Review+1 (3 comments) http://gerrit.cloudera.org:8080/#/c/7171/1/be/src/statestore/statestore-test.cc File be/src/statestore/statestore-test.cc: Line 76: int subscriber_port = FindUnusedEphemeralPort(&used_ports); > Is this the right place for it? Seems more like a unit test for FindUnusedE I agree that adding a unit test would be the best place to put this but is probably not worth it. I thought adding it here will serve as a smoke test of sorts in case that functionality ever breaks inside FindUnusedEphemeralPort(). I'm also ok with leaving it as it is. http://gerrit.cloudera.org:8080/#/c/7171/1/be/src/util/network-util.cc File be/src/util/network-util.cc: Line 197: } > Changed back to a for() loop, which achieves the same thing. I was thinking Thanks. I think this way it is also more obvious that the loop will always terminate. http://gerrit.cloudera.org:8080/#/c/7171/1/be/src/util/network-util.h File be/src/util/network-util.h: Line 70: int FindUnusedEphemeralPort(std::vector<int>* used_ports); > I hit a compile error that I couldn't get around. Unsure if it's a compiler I agree, let's keep it as is then. -- To view, visit http://gerrit.cloudera.org:8080/7171 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id02c83e6f946a14b83f5e6561957d7ad81442835 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: anujphadke <[email protected]> Gerrit-HasComments: Yes
