Joe McDonnell has posted comments on this change. Change subject: IMPALA-5389: simplify BufferDescriptor lifetime ......................................................................
Patch Set 1: (4 comments) First pass looks good. A few minor comments. http://gerrit.cloudera.org:8080/#/c/7182/1//COMMIT_MSG Commit Message: PS1, Line 11: test. test? PS1, Line 18: was did not did not http://gerrit.cloudera.org:8080/#/c/7182/1/be/src/runtime/disk-io-mgr.h File be/src/runtime/disk-io-mgr.h: PS1, Line 150: recycling of the buffer descriptor Since we no longer reuse the buffer descriptor, I think this comment should change. http://gerrit.cloudera.org:8080/#/c/7182/1/be/src/runtime/row-batch.h File be/src/runtime/row-batch.h: PS1, Line 217: std::unique_ptr<DiskIoMgr::BufferDescriptor>&& buffer I believe this can be std::unique_ptr<DiskIoMgr::BufferDescriptor>, since we take ownership in all cases. I could be wrong. -- To view, visit http://gerrit.cloudera.org:8080/7182 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I007d098e9a1abb1f684be37b7f1ee6c03d3879b2 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-HasComments: Yes
