Henry Robinson has posted comments on this change. Change subject: IMPALA-4669: [KUTIL] Add kudu_util library to the build. ......................................................................
Patch Set 13: (1 comment) http://gerrit.cloudera.org:8080/#/c/5715/13/be/src/kudu/util/minidump.cc File be/src/kudu/util/minidump.cc: PS13, Line 96: namespace kudu { > Just wondering if things will break if we remove this file or simply delete We could just remove it from CMakeLists.txt (we already do that for another source file). That would ensure the code was never used, but would simplify refreshing the util source directory. What do you think? Eventually, I would like to both a) consider unifying our code and theirs for common utilities like this and b) selectively disable more files to reduce compilation time / binary size. -- To view, visit http://gerrit.cloudera.org:8080/5715 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8da798ee55506d6f969416b17c191eb03cb215f5 Gerrit-PatchSet: 13 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Henry Robinson <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
