Alex Behm has posted comments on this change. Change subject: IMPALA-4622: Add ALTER COLUMN statement. ......................................................................
Patch Set 5: (6 comments) http://gerrit.cloudera.org:8080/#/c/6955/5/fe/src/main/java/org/apache/impala/analysis/AlterTableAlterColStmt.java File fe/src/main/java/org/apache/impala/analysis/AlterTableAlterColStmt.java: Line 48: remove blank line Line 113: for (Column c : t.getClusteringColumns()) { Instead of this you can pass the Column into Table.isClusteringColumn() on L125 http://gerrit.cloudera.org:8080/#/c/6955/4/fe/src/main/java/org/apache/impala/analysis/AlterTableChangeColStmt.java File fe/src/main/java/org/apache/impala/analysis/AlterTableChangeColStmt.java: Line 56 > The behavior is the same either way - if the column is nullable, it gets th Interesting. Thanks for explaining. http://gerrit.cloudera.org:8080/#/c/6955/5/testdata/workloads/functional-query/queries/QueryTest/kudu_alter.test File testdata/workloads/functional-query/queries/QueryTest/kudu_alter.test: Line 497: # set a non-nullable column's default to null also explain that this is equivalent do DROP DEFAULT which is consistent with Postgres behavior http://gerrit.cloudera.org:8080/#/c/6955/5/tests/query_test/test_kudu.py File tests/query_test/test_kudu.py: Line 366: pytest.skip("only runs in exhaustive") Only runs in exhaustive to reduce core time. Line 388: cursor.execute("""insert into %s values (0, true, 0, 0, 0, 0, 0, 0, '0', Doesn't this result in a PK conflict? I suggest adding a new row in every iteration. -- To view, visit http://gerrit.cloudera.org:8080/6955 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id2e8bd65342b79644a0fdcd925e6f17797e89ad6 Gerrit-PatchSet: 5 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-HasComments: Yes
