Dan Hecht has posted comments on this change. Change subject: IMPALA-5315: Cast to timestamp fails for YYYY-M-D format ......................................................................
Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/7009/5/be/src/runtime/timestamp-parse-util.cc File be/src/runtime/timestamp-parse-util.cc: Line 291: // If we failed to parse using the default templates we will try lazy format. how much slower is it doing it this way, compared to using a stamped out format? if slower, you could try to generate the DateTimeFormatContext directly rather than the format string which is then parsed again, and then if we can make that fast enough, just use this technique for all cases. -- To view, visit http://gerrit.cloudera.org:8080/7009 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib9a184a09d7e7783f04d47588537612c2ecec28f Gerrit-PatchSet: 5 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Vincent Tran <vtt...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Vincent Tran <vtt...@cloudera.com> Gerrit-HasComments: Yes
