Tim Armstrong has posted comments on this change. Change subject: IMPALA-3643/IMPALA-5344: Fix FE tests on Java 8 ......................................................................
Patch Set 6: (12 comments) Looks good. Just have minor comments then I'm ready to +1. I think Alex or Dimitris should still have a pass over and confirm it makes sense ot them. http://gerrit.cloudera.org:8080/#/c/7073/6/fe/src/main/cup/sql-parser.cup File fe/src/main/cup/sql-parser.cup: PS6, Line 1485: HashMap LinkedHashMap? PS6, Line 1528: Map LinkedHashMap? PS6, Line 1695: LinkedHashMap? PS6, Line 1908: HashMap LinkedHashMap? http://gerrit.cloudera.org:8080/#/c/7073/6/fe/src/main/java/org/apache/impala/analysis/AnalysisContext.java File fe/src/main/java/org/apache/impala/analysis/AnalysisContext.java: PS6, Line 444: Map LinkedHashMap? I don't feel as strongly about this one since it doesn't cross module boundaries. http://gerrit.cloudera.org:8080/#/c/7073/6/fe/src/main/java/org/apache/impala/analysis/Analyzer.java File fe/src/main/java/org/apache/impala/analysis/Analyzer.java: Line 179: // LinkeHashSet where applicable to preserve the iteration order and make the class typo http://gerrit.cloudera.org:8080/#/c/7073/6/fe/src/main/java/org/apache/impala/analysis/ColumnLineageGraph.java File fe/src/main/java/org/apache/impala/analysis/ColumnLineageGraph.java: PS6, Line 171: getSources getOrderedSources()? PS6, Line 176: getTargets Maybe getOrderedTargets()? PS6, Line 194: Map LinkedHashMap? Line 342: for (String target: Sets.newTreeSet(targets)) { It might be more efficient to use Guava's ImmutableSortedSet here and above. It gives you back a Set<> backed by a sorted array. I don't feel that strongly but it seems like it would be easy enough. http://gerrit.cloudera.org:8080/#/c/7073/6/fe/src/main/java/org/apache/impala/analysis/ToSqlUtils.java File fe/src/main/java/org/apache/impala/analysis/ToSqlUtils.java: PS6, Line 187: HashMap LinkedHashMap? PS6, Line 211: HashMap LinkedHashMap? -- To view, visit http://gerrit.cloudera.org:8080/7073 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iad8e1dccec3a51293a109c420bd2b88b9d1e0625 Gerrit-PatchSet: 6 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogian...@cloudera.com> Gerrit-Reviewer: Jim Apple <jbapple-imp...@apache.org> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Taras Bobrovytsky <tbobrovyt...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-HasComments: Yes
