Alex Behm has posted comments on this change. Change subject: IMPALA-5431: Remove redundant path exists check during table load ......................................................................
Patch Set 2: (5 comments) http://gerrit.cloudera.org:8080/#/c/7095/2/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java File fe/src/main/java/org/apache/impala/catalog/HdfsTable.java: Line 267: if (partsByPath.size() == 0 || !fs.exists(dirPath)) return; Is this exists() really needed? We are going to do a listFiles() which throws is the path does not exist. In that sense this separate check seems unnecessary. Line 647: if (fs.exists(tblLocation)) { We check exists() inside getAvailableAccessLevel() Line 707: if (!fs.exists(partDir)) { listStatus() throws if the path does not exist, in that sense this check seems redundant Line 1108: if (fs.exists(location)) { exists() is checked inside getAvailableAccessLevel() Line 1662: if (!fs.exists(path)) return; Is this really necessary? Whatever we do inside getAllPartitionsNotInHms() should be able to detect the non-existence as part of the operation -- To view, visit http://gerrit.cloudera.org:8080/7095 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id10ecf64ea2eda2d0f9299c0aa371933eca22281 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-HasComments: Yes
