Matthew Jacobs has posted comments on this change. Change subject: IMPALA-2546: Fix handling of invalid timezones ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7216/1/be/src/exprs/timestamp-functions.cc File be/src/exprs/timestamp-functions.cc: Line 110: context->AddWarning(msg.c_str()); > The test case for this code path has already been added as a part of IMPALA I don't see an end-to-end test that covers this. -- To view, visit http://gerrit.cloudera.org:8080/7216 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I587a16bb8e835a6eea02e1f87fd4033686e84d0f Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-HasComments: Yes
