Alex Behm has posted comments on this change. Change subject: IMPALA-5562: Only recomputeMemLayout() if tuple has a layout. ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7264/1/fe/src/main/java/org/apache/impala/planner/SingleNodePlanner.java File fe/src/main/java/org/apache/impala/planner/SingleNodePlanner.java: Line 245: collSlotRef.getDesc().getParent().recomputeMemLayout(); > Have you considered returning early instead of the Precondition in recomput Not sure I follow the suggestion. I think the Preconditions check in recomputeMemLayout() id definitely correct. We should not unnecessarily compute a mem layout. Where do you suggest I return early? Returning from here is not correct, because you need to finish the loop. -- To view, visit http://gerrit.cloudera.org:8080/7264 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I08548c6bfa7dbf4655e55636605bebb89d2a2239 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-HasComments: Yes
