Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5554: sorter DCHECK on null column ......................................................................
IMPALA-5554: sorter DCHECK on null column The bug was in the DCHECK. The DCHECK is intended to make sure that a tuple's string data didn't get split across blocks. The logic assumed that if the second-or-later string column was in the next-block, that the strings were split between blocks. However, that assumption is invalid if there are NULL strings, which do not belong in any block. The fix for the DCHECK (which is still useful) is to count the number of non-NULL strings and make sure that no non-NULL strings were split between blocks. Testing: Added a test that reproduces the crash. Change-Id: I7a8dee982501008efff5b5abc192cfb5e6544a90 Reviewed-on: http://gerrit.cloudera.org:8080/7295 Reviewed-by: Tim Armstrong <[email protected]> Tested-by: Impala Public Jenkins --- M be/src/runtime/sorter.cc M testdata/workloads/functional-query/queries/QueryTest/single-node-large-sorts.test 2 files changed, 39 insertions(+), 3 deletions(-) Approvals: Impala Public Jenkins: Verified Tim Armstrong: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/7295 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7a8dee982501008efff5b5abc192cfb5e6544a90 Gerrit-PatchSet: 5 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]>
