anujphadke has posted comments on this change. Change subject: IMPALA-4848: Add WIDTH_BUCKET() function ......................................................................
Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/6023/5/be/src/exprs/math-functions-ir.cc File be/src/exprs/math-functions-ir.cc: Line 452: // We can store the results in a decimal8Value. But this change hard codes to > It would be good to summarize the calculations and comment on the chosen ty Done. Do you think it would useful to move the comments at relevant places inside the functions instead of adding it before the definition? -- To view, visit http://gerrit.cloudera.org:8080/6023 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I081bc916b1bef7b929ca161a9aade3b54c6b858f Gerrit-PatchSet: 6 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: anujphadke <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-Reviewer: anujphadke <[email protected]> Gerrit-HasComments: Yes
