Dan Hecht has posted comments on this change. Change subject: IMPALA-5281: stress test: introduce stricter pass guidelines ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/7282/2/tests/stress/concurrent_select.py File tests/stress/concurrent_select.py: PS2, Line 443: self._num_queries_timedout.value - self._num_queries_cancelled.value just curious, what's the relationship between "timed out" and "cancelled" queries? I always thought timed out means hung and cancelled were the deliberately cancelled queries (to test cancellation), but apparently, and so don't see why the bookkeeping is related, but I must be missing something? (But I also see this is consistent with line 713 and so does seem "correct"). -- To view, visit http://gerrit.cloudera.org:8080/7282 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9f2174a527193ae01be45b8ed56315c465883346 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Michael Brown <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: David Knupp <[email protected]> Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Matthew Mulder <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-HasComments: Yes
