Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5588: Reduce the frequency of fault injection ......................................................................
IMPALA-5588: Reduce the frequency of fault injection Previously, the fault injection utility will inject a fault on every 3 RPC calls for ReportExecStatus() RPCs. As shown in IMPALA-5588, with an unfortunate sequence in which other RPCs happen between the retry of ReportExecStatus() RPC in QueryState::ReportExecStatusAux(), ReportExecStatus() can hit injected faults 3 times in a row, causing the query to be cancelled in QueryState::ReportExecStatusAux(). This change fixes the problem by reducing the fault injection frequency to once every 16 RPC calls for ReportExecStatus(), CancelQueryFInstances() and ExecQueryFInstances() RPCs. Also incorporated the fix by Michael Brown for a python bug in test_rpc_exception.py so tests hitting unexpected exception will re-throw that exception for better diagnosis on test failure. Change-Id: I0ce4445e8552a22f23371bed1196caf7d0a3f312 Reviewed-on: http://gerrit.cloudera.org:8080/7310 Reviewed-by: Michael Ho <[email protected]> Tested-by: Impala Public Jenkins --- M be/src/runtime/backend-client.h M tests/custom_cluster/test_rpc_exception.py 2 files changed, 7 insertions(+), 5 deletions(-) Approvals: Impala Public Jenkins: Verified Michael Ho: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/7310 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0ce4445e8552a22f23371bed1196caf7d0a3f312 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Michael Ho <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]>
