Donghui Xu has posted comments on this change.

Change subject: IMPALA-5513: Fix display message exception when using invalid 
KEYVAL
......................................................................


Patch Set 4:

(2 comments)

I have modified the code according to your opinion.
I think your advice is fine, but how do i know who is familiar with that file?

http://gerrit.cloudera.org:8080/#/c/7187/2//COMMIT_MSG
Commit Message:

PS2, Line 9: 
> Please do not end lines in spaces.
Done


PS2, Line 13:  print_to_stder
> Functions are usually written "print_to_stderr()" - preserving capitalizati
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/7187
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib883499a88f39d91b69bea4291f1ce5dd264ccf6
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Donghui Xu <[email protected]>
Gerrit-Reviewer: Donghui Xu <[email protected]>
Gerrit-Reviewer: Jim Apple <[email protected]>
Gerrit-HasComments: Yes

Reply via email to