Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-5611: KuduPartitionExpr holds onto memory unnecessarily ......................................................................
Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/7346/4/be/src/runtime/data-stream-sender.cc File be/src/runtime/data-stream-sender.cc: Line 482: RETURN_IF_ERROR(state->CheckQueryState()); > this is fine, but any reason to not just hoist it from the if-stmt to here, Done -- To view, visit http://gerrit.cloudera.org:8080/7346 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia661eb8bed114070728a1497ccf7ed6893237e5e Gerrit-PatchSet: 5 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
