Dan Hecht has posted comments on this change. Change subject: IMPALA-5580: fix Java UDFs that return NULL strings ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7364/1/be/src/exprs/hive-udf-call.cc File be/src/exprs/hive-udf-call.cc: Line 330: if (result.is_null) return StringVal::null(); > Can't we make CopyFrom() return a String::null() instead of an empty string CopyFrom() doesn't take a StringVal (a lot of call sites generate the string "on the fly" rather than copying from a StringVal). I don't think we should add another interface for this, since the UDF interface is already too complicated. -- To view, visit http://gerrit.cloudera.org:8080/7364 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I34d288aad66a2609484058c9a177c02200cb6a6e Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Dan Hecht <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
