Michael Ho has posted comments on this change. Change subject: IMPALA-5031: Set DiskIoMgr::ScanRange::is_cancelled_ before read ......................................................................
Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/7294/2/be/src/runtime/disk-io-mgr.h File be/src/runtime/disk-io-mgr.h: PS2, Line 584: is_cancelled_ = false; > I would prefer to keep this patch within the bounds of only fixing the unde May be I am mistaken but it appears that Reset() is only used in tests. However, if you decide to not do so in this patch, please file a JIRA if necessary so it doesn't get forgotten. It seems that we also need to rest eosr_queued_ and eosr_returned_ and possibly other flags in Reset() Now that the bool flags are initialized here, the constructor probably doesn't have to do so. -- To view, visit http://gerrit.cloudera.org:8080/7294 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I22898ec96ac44c4902f8072f27453cfc58358cae Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Jim Apple <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-HasComments: Yes
