Michael Brown has posted comments on this change. Change subject: IMPALA-5625: write profile when query times out ......................................................................
Patch Set 1: (6 comments) Nice! http://gerrit.cloudera.org:8080/#/c/7376/1//COMMIT_MSG Commit Message: Line 22: We typically have a testing done section. http://gerrit.cloudera.org:8080/#/c/7376/1/tests/stress/concurrent_select.py File tests/stress/concurrent_select.py: PS1, Line 691: "{0}" Please add query ID: to the string here. Line 699: raise Exception( Can you also add support for saving profiles when incorrect results occur? PS1, Line 704: {0} Please add "query ID" to the string. PS1, Line 748: if not (report.profile and report.query_id): : return Do you know often this path is executed? PS1, Line 1704: "--result-hash-log-dir" Now that this contains profiles, too, should this be renamed? -- To view, visit http://gerrit.cloudera.org:8080/7376 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1dbdf5fcf97d6c5681c9fc8fb9eb448bc459b3b0 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Matthew Mulder <[email protected]> Gerrit-Reviewer: David Knupp <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-Reviewer: Tim Wood <[email protected]> Gerrit-HasComments: Yes
