Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5629: avoid expensive list::size() call ......................................................................
IMPALA-5629: avoid expensive list::size() call As a workaround until we move to GCC5+, explicitly track the pages_ list size. This is not too bad in practice since it is only mutated in 3 places. Testing: Ran buffered-tuple-stream-v2-test (the only coverage of BufferedTupleStreamV2 currently). Reran the query with the perf issue, confirmed that it was no longer spending lots of time in BufferedTupleStreamV2::AdvanceWritePage(). Change-Id: Id83fcf68dcc3ea729df167885f999ff32b861e66 Reviewed-on: http://gerrit.cloudera.org:8080/7382 Reviewed-by: Dan Hecht <[email protected]> Tested-by: Impala Public Jenkins --- M be/src/runtime/buffered-tuple-stream-v2.cc M be/src/runtime/buffered-tuple-stream-v2.h 2 files changed, 21 insertions(+), 13 deletions(-) Approvals: Impala Public Jenkins: Verified Dan Hecht: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/7382 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id83fcf68dcc3ea729df167885f999ff32b861e66 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]>
