Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5511: Add process start time to debug web page ......................................................................
Patch Set 3: > Sure, I'll create a similar start-time metric for this 2 processes > as well. Some question though: > 1) With this approach there is no need to keep my changes in > process-state-info, right? > 2) Which of the boost functions are used officially to replace > TimestampValue? Great, thanks Gabor. Yes, I think there's no reason to keep the change in process-state-info. I think you can ignore my comment about TimestampValue for now, we can address that in a separate change. Please just leave a TODO with the JIRA I mentioned earlier. Thanks! -- To view, visit http://gerrit.cloudera.org:8080/7363 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I05ae2f80835b1b0e4bc3b38731778ba0871338a4 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Attila Jeges <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Laszlo Gaal <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: No
