Dan Hecht has posted comments on this change. Change subject: IMPALA-5539: Kudu timestamp scans wrong with -use_local_tz_for_unix_ts ......................................................................
Patch Set 2: (2 comments) This looks fine to me once you add the tests. Let's still do the refactoring/renaming follow on. It's way harder to read the timestamp code than it should be. http://gerrit.cloudera.org:8080/#/c/7311/2/be/src/runtime/timestamp-value.h File be/src/runtime/timestamp-value.h: PS2, Line 285: the time zone of i think you can delete that part PS2, Line 289: time zone of same -- To view, visit http://gerrit.cloudera.org:8080/7311 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I423a810427353be76aa64442044133a9a22cdc9b Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-HasComments: Yes
