Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-5513: Fix display message exception when using invalid KEYVAL ......................................................................
Patch Set 6: -Code-Review Sorry for holding this up, didn't realize it was waiting on me until Jim pointed out (thanks Jim). So I think it is ok to club those tests together. We generally group them by functionality and in this case I don't think we need to create a separate unit test function for such a trivial test. -- To view, visit http://gerrit.cloudera.org:8080/7187 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib883499a88f39d91b69bea4291f1ce5dd264ccf6 Gerrit-PatchSet: 6 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Donghui Xu <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Donghui Xu <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-HasComments: No
