Sailesh Mukil has posted comments on this change. Change subject: IMPALA-5667: Race in DataStremSender could cause TransmitData sidecar corruption ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7436/1/be/src/runtime/data-stream-sender.cc File be/src/runtime/data-stream-sender.cc: PS1, Line 192: if (recvr_gone_) { : return Status(TErrorCode::DATASTREAM_RECVR_ALREADY_GONE); : } else if (parent_->closed_) { : return Status("DataStreamSender already closed"); > Don't errors from this method propagate to the coordinator, via FragmentIns Ah yes, you're right. I forgot that recvr_gone_ can be true in cases where the receiver hits the limit before the sender completes sending, and goes away, so we shouldn't treat it as an error case. Also, a closed sender doesn't warrant an error. I'll make this change. -- To view, visit http://gerrit.cloudera.org:8080/7436 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7742551236205c49393a7351291eae6aefb4fa09 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-HasComments: Yes
