Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5657: Fix a couple of bugs with FunctionCallExpr and IGNORE NULLS ......................................................................
Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/7416/2/fe/src/main/java/org/apache/impala/analysis/FunctionCallExpr.java File fe/src/main/java/org/apache/impala/analysis/FunctionCallExpr.java: PS2, Line 172: equals Seems like a bug potentially not including it in this comparison. I haven't traced through the code enough to figure out if there are any real issues introduced by not having it here (e.g. comparing "foo IGNORE NULLS == foo" is true but shouldn't be), but seems like a good idea to add it to the conditions below. PS2, Line 196: debugString Probably should be here too http://gerrit.cloudera.org:8080/#/c/7416/2/fe/src/test/java/org/apache/impala/analysis/ToSqlTest.java File fe/src/test/java/org/apache/impala/analysis/ToSqlTest.java: Line 1174: nit extra line -- To view, visit http://gerrit.cloudera.org:8080/7416 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I723897886c95763c3f29d6f24c4d9e7d43898ade Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-HasComments: Yes
