Bikramjeet Vig has uploaded a new patch set (#2). Change subject: IMPALA-5275: Avoid printing status stack trace on hot paths ......................................................................
IMPALA-5275: Avoid printing status stack trace on hot paths Currently, creation of a Status object (non-OK and non-EXPECTED) prints the stack trace to the log. Fetching the stack trace takes a large chunk of CPU time close to 130ms and results in a significant perf hit when encountered on hot paths. Five such hot paths were identified and the following changes were made to fix it: 1. In ImpalaServer::GetExecSummary(), create Status() without holding the query_log_lock_. 2, 3 and 4. In impala::DeserializeThriftMsg<>(), PartitionedAggregationNode::CodegenUpdateTuple() and HdfsScanner::CodegenWriteCompleteTuple, use Status::Expected where appropriate. 5. In Status::MemLimitExceeded(), create Status object without printing stacktrace Change-Id: Ief083f558fba587381aa7fe8f99da279da02f1f2 --- M be/src/common/status.cc M be/src/exec/hdfs-scanner.cc M be/src/exec/partitioned-aggregation-node.cc M be/src/rpc/thrift-util.h M be/src/service/impala-server.cc 5 files changed, 28 insertions(+), 16 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/49/7449/2 -- To view, visit http://gerrit.cloudera.org:8080/7449 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ief083f558fba587381aa7fe8f99da279da02f1f2 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]>
