Tim Armstrong has posted comments on this change. Change subject: IMPALA-5615: Fix compute incremental stats for general partition exprs ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7379/1/fe/src/main/java/org/apache/impala/analysis/ComputeStatsStmt.java File fe/src/main/java/org/apache/impala/analysis/ComputeStatsStmt.java: Line 361: Sets.newHashSet(partitionSet_.getPartitions()); I don't fully understand the motivation for this part of the change. Does getPartitions() return duplicates? If so, it might be better to add a getUniquePartitions() method to PartitionSet Also, I think we should also use LinkedHashSet or a sorted set here so that the SQL generated is deterministic. -- To view, visit http://gerrit.cloudera.org:8080/7379 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I227fc06f580eb9174f60ad0f515a3641cec19268 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
