Sailesh Mukil has posted comments on this change. Change subject: IMPALA-5489: Improve Sentry authorization for Kudu tables ......................................................................
Patch Set 2: Code-Review+1 (3 comments) http://gerrit.cloudera.org:8080/#/c/7307/2//COMMIT_MSG Commit Message: PS2, Line 23: (or : SELECT and INSERT) Update comment and mention the behavior change if you think it's appropriate. http://gerrit.cloudera.org:8080/#/c/7307/2/fe/src/main/java/org/apache/impala/analysis/ModifyStmt.java File fe/src/main/java/org/apache/impala/analysis/ModifyStmt.java: PS2, Line 147: // Make sure that the user is allowed to modify the target table, since no : // UPDATE / DELETE privilege exists, we reuse the INSERT one. Update comment. PS2, Line 149: Privilege.ALL This is technically a behavioral change, I'm not sure how many users rely on the existing behavior of these permissions, but in any case we should make sure that this goes out in the release notes for our next release. -- To view, visit http://gerrit.cloudera.org:8080/7307 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib12d2b32fa3e142e69bd8b0f24f53f9e5cbf7460 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-HasComments: Yes
