Lars Volker has posted comments on this change. Change subject: Populate OffsetIndex and ColumnIndex of a row_group and Filter pages ......................................................................
Patch Set 2: (4 comments) Thank you for addressing all the comments. :) http://gerrit.cloudera.org:8080/#/c/7465/2/be/src/exec/hdfs-parquet-scanner.cc File be/src/exec/hdfs-parquet-scanner.cc: Line 537: return Status::OK(); A comment might help to understand why you abort altogether here. Why is it not necessary to cancel the scan ranges? http://gerrit.cloudera.org:8080/#/c/7465/2/be/src/exec/parquet-index-filter.cc File be/src/exec/parquet-index-filter.cc: PS2, Line 203: page.page_id = page_idx; : page.first_row_index = first_row_index; These aren't needed anymore now, are they? http://gerrit.cloudera.org:8080/#/c/7465/2/be/src/exec/parquet-index-filter.h File be/src/exec/parquet-index-filter.h: PS2, Line 50: FilteredPages FilteredPageInfos may be more clear. http://gerrit.cloudera.org:8080/#/c/7465/2/tests/query_test/test_insert_parquet.py File tests/query_test/test_insert_parquet.py: Line 747: assert decode_stats_value(schema, value) <= max_value No need to change it now, but this line has now ~10 levels of indent. :) -- To view, visit http://gerrit.cloudera.org:8080/7465 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idace1e57067f95973cef3567eeb84f2ad87fd3f6 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Pooja Nilangekar <pooja.nilange...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Pooja Nilangekar <pooja.nilange...@cloudera.com> Gerrit-HasComments: Yes
